On Thu, Jan 28, 2021 at 4:45 PM Tony Nguyen <anthony.l.ngu...@intel.com> wrote:
>
> From: Aleksandr Loktionov <aleksandr.loktio...@intel.com>
>
> This reverts commit 2ad1274fa35ace5c6360762ba48d33b63da2396c
>
> VF queues were not brought up when PF was brought up after being
> downed if the VF driver disabled VFs queues during PF down.
> This could happen in some older or external VF driver implementations.
> The problem was that PF driver used vf->queues_enabled as a condition
> to decide what link-state it would send out which caused the issue.
>
> Remove the check for vf->queues_enabled in the VF link notify.
> Now VF will always be notified of the current link status.
> Also remove the queues_enabled member from i40e_vf structure as it is
> not used anymore. Otherwise VNF implementation was broken and caused
> a link flap.
>
> Fixes: 2ad1274fa35a ("i40e: don't report link up for a VF who hasn't enabled")
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktio...@intel.com>
> Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalew...@intel.com>
> Tested-by: Konrad Jankowski <konrad0.jankow...@intel.com>
> Signed-off-by: Tony Nguyen <anthony.l.ngu...@intel.com>Doesn't this reintroduce the bug that the original patch aimed to solve? Commit 2ad1274fa35a itself was also a fix.
