> On Sat, 12 Dec 2020 18:41:48 +0100 > Lorenzo Bianconi <lore...@kernel.org> wrote: > > > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c > > b/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c > > index fcc262064766..b7942c3440c0 100644 > > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c > > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c > > @@ -133,12 +133,11 @@ bool bnxt_rx_xdp(struct bnxt *bp, struct > > bnxt_rx_ring_info *rxr, u16 cons, > > dma_sync_single_for_cpu(&pdev->dev, mapping + offset, *len, bp->rx_dir); > > > > txr = rxr->bnapi->tx_ring; > > + xdp_init_buff(&xdp, PAGE_SIZE, &rxr->xdp_rxq); > > xdp.data_hard_start = *data_ptr - offset; > > xdp.data = *data_ptr; > > xdp_set_data_meta_invalid(&xdp); > > xdp.data_end = *data_ptr + *len; > > - xdp.rxq = &rxr->xdp_rxq; > > - xdp.frame_sz = PAGE_SIZE; /* BNXT_RX_PAGE_MODE(bp) when XDP enabled */ > > orig_data = xdp.data; > > I don't like loosing the comment here. Other developers reading this > code might assume that size is always PAGE_SIZE, which is only the case > when XDP is enabled. Lets save them from making this mistake.
ack, I will add it back in v4. Regards, Lorenzo > > -- > Best regards, > Jesper Dangaard Brouer > MSc.CS, Principal Kernel Engineer at Red Hat > LinkedIn: http://www.linkedin.com/in/brouer >
signature.asc
Description: PGP signature
