Re: [PATCH net-next v4 10/15] net/smc: Introduce SMCR get link command

[Jakub Kicinski]

On Mon,  9 Nov 2020 16:18:09 +0100 Karsten Graul wrote:
> @@ -129,6 +131,12 @@ struct smc_diag_linkinfo {
>       __u8 ibport;                    /* RDMA device port number */
>       __u8 gid[40];                   /* local GID */
>       __u8 peer_gid[40];              /* peer GID */
> +     /* Fields above used by legacy v1 code */
> +     __u32 conn_cnt;
> +     __u8 netdev[IFNAMSIZ];          /* ethernet device name */

Why report the name? Interfaces are generally identified by ifindex.

> +     __u8 link_uid[4];               /* unique link id */
> +     __u8 peer_link_uid[4];          /* unique peer link id */
> +     __u32 link_state;               /* link state */
>  };