On Wed, Nov 04, 2020 at 06:55:24AM +0100, Marek Behún wrote: > On Tue, 3 Nov 2020 23:47:12 +0200 > Vladimir Oltean <olte...@gmail.com> wrote: > > > On Tue, Nov 03, 2020 at 08:22:24PM +0100, Marek Behún wrote: > > > Add pla_ and usb_ prefixed versions of ocp_read_* and ocp_write_* > > > functions. This saves us from always writing MCU_TYPE_PLA/MCU_TYPE_USB > > > as parameter. > > > > > > Signed-off-by: Marek Behún <ka...@kernel.org> > > > --- > > > > You just made it harder for everyone to follow the code through pattern > > matching. Token concatenation should be banned from the C preprocessor. > > So you aren't complaining about the definition of pla_ and usb_ > functions, just that they are defined via macros?
Yes.
