> I suppose that part would be pretty harmless, as you would likely want
> that behavior whenever that if condition was triggered. So
> m88e1111_finisar_config_init could likely be merged into
> m88e1111_config_init.
I think so as well.
> Mainly what stopped me from making all of these changes generic to all
> 88E1111 is that I'm a bit less confident in the different config_aneg
> behavior, it might be more specific to this SFP copper module case?
Well, for 1000BaseX, i don't think we currently have an SFP devices
using it, since phylink does not support it. So it is a question are
there any none-SFP m88e1111 out there you might break?
Andrew
