Re: [PATCH net-next 9/9] bnxt_en: Add stored FW version info to devlink info_get cb.

[Jakub Kicinski]

On Sun, 11 Oct 2020 06:23:01 -0400 Michael Chan wrote:
> +     rc = bnxt_hwrm_nvm_get_dev_info(bp, &nvm_dev_info);
> +     if (rc)
> +             return rc;

This will not cause an error to be returned for the entire operation on
older FW or HW, right?

> +     if (!(nvm_dev_info.flags & NVM_GET_DEV_INFO_RESP_FLAGS_FW_VER_VALID))
> +             return 0;


> +     rc = bnxt_dl_info_put(bp, req, BNXT_VERSION_STORED,
> +                           DEVLINK_INFO_VERSION_GENERIC_FW_ROCE, roce_ver);
>       return rc;

return bnxt_dl_info_put(bp, req, BNXT_VERSION_STORED,
                        DEVLINK_INFO_VERSION_GENERIC_FW_ROCE, roce_ver);