On Thu, 2020-10-01 at 17:36 -0700, Jakub Kicinski wrote: > On Thu, 1 Oct 2020 15:59:23 -0700 Jakub Kicinski wrote: > > Hi! > > > > The objective of this series is to dump ethtool policies > > to be able to tell which flags are supported by the kernel. > > Current release adds ETHTOOL_FLAG_STATS for dumping extra > > stats, but because of strict checking we need to make sure > > that the flag is actually supported before setting it in > > a request. > > Do we need support for separate .doit and .dumpit policies? > Or is that an overkill?
I suppose you could make an argument that only some attrs might be accepted in doit and somewhat others in dumpit, or perhaps none in dumpit because filtering wasn't implemented? But still ... often we treat filtering as "advisory" anyway (except perhaps where there's no doit at all, like the dump_policy thing here), so it wouldn't matter if some attribute is ending up ignored? johannes
