>  static int pause_prepare_data(const struct ethnl_req_info *req_base,
> @@ -34,10 +36,17 @@ static int pause_prepare_data(const struct ethnl_req_info 
> *req_base,
>  
>       if (!dev->ethtool_ops->get_pauseparam)
>               return -EOPNOTSUPP;
> +
>       ret = ethnl_ops_begin(dev);
>       if (ret < 0)
>               return ret;
>       dev->ethtool_ops->get_pauseparam(dev, &data->pauseparam);
> +     if (req_base->flags & ETHTOOL_FLAG_STATS &&
> +         dev->ethtool_ops->get_pause_stats) {
> +             memset(&data->pausestat, 0xff,
> +                    sizeof(struct ethtool_pause_stats));

Sorry, i missed v1 of these patches. Maybe this has been commented?

Filling with 0xff is odd. I don't know of any other code doing this.

        Andrew

Reply via email to