Hi Jakub, I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Jakub-Kicinski/ethtool-add-pause-frame-stats/20200912-073106 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 9984c0bb22dcae688ef8588e2621133850ff49bc config: alpha-allyesconfig (attached as .config) compiler: alpha-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): drivers/net/ethernet/mellanox/mlx5/core/en_rep.c: In function 'mlx5e_uplink_rep_get_pause_stats': >> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:296:30: error: >> 'pause_stats' undeclared (first use in this function) 296 | mlx5e_stats_pause_get(priv, pause_stats); | ^~~~~~~~~~~ drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:296:30: note: each undeclared identifier is reported only once for each function it appears in # https://github.com/0day-ci/linux/commit/17559603fedf69b369c0ebe597dc2e6ac5369167 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jakub-Kicinski/ethtool-add-pause-frame-stats/20200912-073106 git checkout 17559603fedf69b369c0ebe597dc2e6ac5369167 vim +/pause_stats +296 drivers/net/ethernet/mellanox/mlx5/core/en_rep.c 290 291 static void mlx5e_uplink_rep_get_pause_stats(struct net_device *netdev, 292 struct ethtool_pause_stats *stats) 293 { 294 struct mlx5e_priv *priv = netdev_priv(netdev); 295 > 296 mlx5e_stats_pause_get(priv, pause_stats); 297 } 298 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
