> It also is not true that the current code ensures your assertion. > Specifically, phy_advertise_supported copies the pause bits from the old > advertised to the new one regardless of whether they're set in > supported.
This is an oddity of Pause. The PHY should not sets Pause in supported, because the PHY is not the device which implements Pause. The MAC needs to indicate to PHYLIB it implements Pause, and then the PHY will advertise Pause. I will address the other points in a separate email. Andrew
