Hi Florian, On Thu Jun 18 2020, Florian Fainelli wrote: > On 6/17/2020 11:40 PM, Kurt Kanzenbach wrote: >> Add basic documentation and example. >> >> Signed-off-by: Kurt Kanzenbach <k...@linutronix.de> >> --- >> .../devicetree/bindings/net/dsa/hellcreek.txt | 72 +++++++++++++++++++ >> 1 file changed, 72 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/dsa/hellcreek.txt >> >> diff --git a/Documentation/devicetree/bindings/net/dsa/hellcreek.txt >> b/Documentation/devicetree/bindings/net/dsa/hellcreek.txt >> new file mode 100644 >> index 000000000000..9ea6494dc554 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/dsa/hellcreek.txt > > This should be a YAML binding and we should also convert the DSA binding > to YAML one day.
OK.
>
>> @@ -0,0 +1,72 @@
>> +Hirschmann hellcreek switch driver
>> +==================================
>> +
>> +Required properties:
>> +
>> +- compatible:
>> + Must be one of:
>> + - "hirschmann,hellcreek"
>> +
>> +See Documentation/devicetree/bindings/net/dsa/dsa.txt for the list of
>> standard
>> +DSA required and optional properties.
>> +
>> +Example
>> +-------
>> +
>> +Ethernet switch connected memory mapped to the host, CPU port wired to
>> gmac0:
>> +
>> +soc {
>> + switch0: switch@0xff240000 {
>
> Please remove the leading 0x from the unit address.
Sure.
Thanks,
Kurt
signature.asc
Description: PGP signature
