Hi Roopa, I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master] [also build test WARNING on net/master kselftest/next sparc-next/master linus/master v5.7-rc6 next-20200518] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Roopa-Prabhu/Support-for-fdb-ECMP-nexthop-groups/20200519-185605 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 5cdfe8306631b2224e3f81fc5a1e2721c7a1948b config: um-defconfig (attached as .config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=um If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <l...@intel.com> All warnings (new ones prefixed by >>, old ones prefixed by <<): cc1: warning: arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] In file included from include/linux/kernel.h:11:0, from net/ipv4/ip_tunnel_core.c:9: include/asm-generic/fixmap.h: In function 'fix_to_virt': include/asm-generic/fixmap.h:32:19: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] BUILD_BUG_ON(idx >= __end_of_fixed_addresses); ^ include/linux/compiler.h:330:9: note: in definition of macro '__compiletime_assert' if (!(condition)) ^~~~~~~~~ include/linux/compiler.h:350:2: note: in expansion of macro '_compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) ^~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:50:2: note: in expansion of macro 'BUILD_BUG_ON_MSG' BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) ^~~~~~~~~~~~~~~~ include/asm-generic/fixmap.h:32:2: note: in expansion of macro 'BUILD_BUG_ON' BUILD_BUG_ON(idx >= __end_of_fixed_addresses); ^~~~~~~~~~~~ In file included from include/linux/uaccess.h:11:0, from include/linux/sched/task.h:11, from include/linux/sched/signal.h:9, from include/linux/rcuwait.h:6, from include/linux/percpu-rwsem.h:7, from include/linux/fs.h:34, from include/linux/huge_mm.h:8, from include/linux/mm.h:679, from include/linux/bvec.h:13, from include/linux/skbuff.h:17, from net/ipv4/ip_tunnel_core.c:10: arch/um/include/asm/uaccess.h: In function '__access_ok': arch/um/include/asm/uaccess.h:17:29: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] (((unsigned long) (addr) >= FIXADDR_USER_START) && ^ arch/um/include/asm/uaccess.h:45:3: note: in expansion of macro '__access_ok_vsyscall' __access_ok_vsyscall(addr, size) || ^~~~~~~~~~~~~~~~~~~~ In file included from net/ipv4/ip_tunnel_core.c:38:0: include/net/vxlan.h: In function 'vxlan_fdb_nh_path_select': include/net/vxlan.h:496:8: error: implicit declaration of function 'nexthop_path_fdb_result' [-Werror=implicit-function-declaration] nhc = nexthop_path_fdb_result(nh, hash); ^~~~~~~~~~~~~~~~~~~~~~~ >> include/net/vxlan.h:496:6: warning: assignment makes pointer from integer >> without a cast [-Wint-conversion] nhc = nexthop_path_fdb_result(nh, hash); ^ cc1: some warnings being treated as errors vim +496 include/net/vxlan.h 489 490 static inline bool vxlan_fdb_nh_path_select(struct nexthop *nh, 491 int hash, 492 struct vxlan_rdst *rdst) 493 { 494 struct fib_nh_common *nhc; 495 > 496 nhc = nexthop_path_fdb_result(nh, hash); 497 if (unlikely(!nhc)) 498 return false; 499 500 switch (nhc->nhc_gw_family) { 501 case AF_INET: 502 rdst->remote_ip.sin.sin_addr.s_addr = nhc->nhc_gw.ipv4; 503 rdst->remote_ip.sa.sa_family = AF_INET; 504 break; 505 case AF_INET6: 506 rdst->remote_ip.sin6.sin6_addr = nhc->nhc_gw.ipv6; 507 rdst->remote_ip.sa.sa_family = AF_INET6; 508 break; 509 } 510 511 return true; 512 } 513 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
