On 5/18/20 8:14 PM, Roopa Prabhu wrote: > From: Nikolay Aleksandrov <niko...@cumulusnetworks.com> > > the ->nh pointer might become suddenly null while we're selecting the > path and we may dereference it. Dereference it only once in the > beginning and use that if it's not null, we rely on the refcounting and > rcu to protect against use-after-free. (This is needed for later > vxlan patches that exposes the problem) > > Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> > Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> > --- > net/ipv4/nexthop.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) >
Reviewed-by: David Ahern <dsah...@gmail.com> Should this be a bug fix? Any chance the route path can hit it?