Sat, Oct 19, 2019 at 09:27:50PM CEST, and...@lunn.ch wrote: >> >+address_translation_unit_hash [DEVICE, DRIVER-SPECIFIC] >> >> This is quite verbose. Can't you name this just "atu_hash" and be >> aligned with the function names and MV88E6XXX_DEVLINK_PARAM_ID_ATU_HASH >> and others? > >Hi Jiri > >I would use ATU_hash, but not atu_hash, sorry.
That, I don't understand at all :/ The devlink param namespace is full of abbreviations. For example: iwarp_cmt gre_ver_check enable_sriov ignore_ari msix_vec_per_pf_max msix_vec_per_pf_min fw_load_policy reset_dev_on_drv_probe acl_region_rehash_interval enable_64b_cqe_eqe enable_4k_uar Why your thing is special? Could you please follow the rest of the existing params? > >Hopefully somebody will implement bash command completion, making it >easier. > > Andrew
