Sat, Oct 19, 2019 at 08:52:01PM CEST, and...@lunn.ch wrote: >Some of the marvell switches have bits controlling the hash algorithm >the ATU uses for MAC addresses. In some industrial settings, where all >the devices are from the same manufacture, and hence use the same OUI, >the default hashing algorithm is not optimal. Allow the other >algorithms to be selected via devlink. > >Signed-off-by: Andrew Lunn <and...@lunn.ch> >--- > .../networking/devlink-params-mv88e6xxx.txt | 7 + > MAINTAINERS | 1 + > drivers/net/dsa/mv88e6xxx/chip.c | 132 +++++++++++++++++- > drivers/net/dsa/mv88e6xxx/chip.h | 4 + > drivers/net/dsa/mv88e6xxx/global1.h | 3 + > drivers/net/dsa/mv88e6xxx/global1_atu.c | 32 +++++ > 6 files changed, 178 insertions(+), 1 deletion(-) > create mode 100644 Documentation/networking/devlink-params-mv88e6xxx.txt > >diff --git a/Documentation/networking/devlink-params-mv88e6xxx.txt >b/Documentation/networking/devlink-params-mv88e6xxx.txt >new file mode 100644 >index 000000000000..b6e61108d781 >--- /dev/null >+++ b/Documentation/networking/devlink-params-mv88e6xxx.txt >@@ -0,0 +1,7 @@ >+address_translation_unit_hash [DEVICE, DRIVER-SPECIFIC]
This is quite verbose. Can't you name this just "atu_hash" and be aligned with the function names and MV88E6XXX_DEVLINK_PARAM_ID_ATU_HASH and others? Otherwise, the patch looks fine to me. >+ Select one of four possible hashing algorithms for >+ MAC addresses in the Address Translation Unit. >+ A value of 3 seems to work better than the default of >+ 1 when many MAC addresses have the same OUI. >+ Configuration mode: runtime >+ Type: u8. 0-3 valid. [...]
