On Fri, 4 Oct 2019 11:50:12 +0200, Jiri Pirko wrote: > From: Jiri Pirko <j...@mellanox.com> > > Currently, some dumpit function may end-up with error which is not > -EMSGSIZE and this error is silently ignored. Use does not have clue > that something wrong happened. Instead of silent ignore, propagate > the error to user. > > Suggested-by: Andrew Lunn <and...@lunn.ch> > Signed-off-by: Jiri Pirko <j...@mellanox.com>
I'd personally err on the side of caution and add this non-EMSGSIZE handling to all the *_dumpit() helpers, even those which can only get a size error today, but I guess it's not super likely the errors will change for the more static objects.. Acked-by: Jakub Kicinski <jakub.kicin...@netronome.com>