[patch net-next] net: devlink: don't ignore errors during dumpit

[Jiri Pirko]

From: Jiri Pirko <j...@mellanox.com>

Currently, some dumpit function may end-up with error which is not
-EMSGSIZE and this error is silently ignored. Use does not have clue
that something wrong happened. Instead of silent ignore, propagate
the error to user.

Suggested-by: Andrew Lunn <and...@lunn.ch>
Signed-off-by: Jiri Pirko <j...@mellanox.com>
---
 net/core/devlink.c | 30 ++++++++++++++++++++++++------
 1 file changed, 24 insertions(+), 6 deletions(-)

diff --git a/net/core/devlink.c b/net/core/devlink.c
index e48680efe54a..b7edbd14518b 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -1035,7 +1035,7 @@ static int devlink_nl_cmd_sb_pool_get_dumpit(struct 
sk_buff *msg,
        struct devlink_sb *devlink_sb;
        int start = cb->args[0];
        int idx = 0;
-       int err;
+       int err = 0;
 
        mutex_lock(&devlink_mutex);
        list_for_each_entry(devlink, &devlink_list, list) {
@@ -1058,6 +1058,9 @@ static int devlink_nl_cmd_sb_pool_get_dumpit(struct 
sk_buff *msg,
 out:
        mutex_unlock(&devlink_mutex);
 
+       if (err != -EMSGSIZE)
+               return err;
+
        cb->args[0] = idx;
        return msg->len;
 }
@@ -1233,7 +1236,7 @@ static int devlink_nl_cmd_sb_port_pool_get_dumpit(struct 
sk_buff *msg,
        struct devlink_sb *devlink_sb;
        int start = cb->args[0];
        int idx = 0;
-       int err;
+       int err = 0;
 
        mutex_lock(&devlink_mutex);
        list_for_each_entry(devlink, &devlink_list, list) {
@@ -1256,6 +1259,9 @@ static int devlink_nl_cmd_sb_port_pool_get_dumpit(struct 
sk_buff *msg,
 out:
        mutex_unlock(&devlink_mutex);
 
+       if (err != -EMSGSIZE)
+               return err;
+
        cb->args[0] = idx;
        return msg->len;
 }
@@ -1460,7 +1466,7 @@ devlink_nl_cmd_sb_tc_pool_bind_get_dumpit(struct sk_buff 
*msg,
        struct devlink_sb *devlink_sb;
        int start = cb->args[0];
        int idx = 0;
-       int err;
+       int err = 0;
 
        mutex_lock(&devlink_mutex);
        list_for_each_entry(devlink, &devlink_list, list) {
@@ -1485,6 +1491,9 @@ devlink_nl_cmd_sb_tc_pool_bind_get_dumpit(struct sk_buff 
*msg,
 out:
        mutex_unlock(&devlink_mutex);
 
+       if (err != -EMSGSIZE)
+               return err;
+
        cb->args[0] = idx;
        return msg->len;
 }
@@ -3155,7 +3164,7 @@ static int devlink_nl_cmd_param_get_dumpit(struct sk_buff 
*msg,
        struct devlink *devlink;
        int start = cb->args[0];
        int idx = 0;
-       int err;
+       int err = 0;
 
        mutex_lock(&devlink_mutex);
        list_for_each_entry(devlink, &devlink_list, list) {
@@ -3183,6 +3192,9 @@ static int devlink_nl_cmd_param_get_dumpit(struct sk_buff 
*msg,
 out:
        mutex_unlock(&devlink_mutex);
 
+       if (err != -EMSGSIZE)
+               return err;
+
        cb->args[0] = idx;
        return msg->len;
 }
@@ -3411,7 +3423,7 @@ static int devlink_nl_cmd_port_param_get_dumpit(struct 
sk_buff *msg,
        struct devlink *devlink;
        int start = cb->args[0];
        int idx = 0;
-       int err;
+       int err = 0;
 
        mutex_lock(&devlink_mutex);
        list_for_each_entry(devlink, &devlink_list, list) {
@@ -3444,6 +3456,9 @@ static int devlink_nl_cmd_port_param_get_dumpit(struct 
sk_buff *msg,
 out:
        mutex_unlock(&devlink_mutex);
 
+       if (err != -EMSGSIZE)
+               return err;
+
        cb->args[0] = idx;
        return msg->len;
 }
@@ -4066,7 +4081,7 @@ static int devlink_nl_cmd_info_get_dumpit(struct sk_buff 
*msg,
        struct devlink *devlink;
        int start = cb->args[0];
        int idx = 0;
-       int err;
+       int err = 0;
 
        mutex_lock(&devlink_mutex);
        list_for_each_entry(devlink, &devlink_list, list) {
@@ -4094,6 +4109,9 @@ static int devlink_nl_cmd_info_get_dumpit(struct sk_buff 
*msg,
        }
        mutex_unlock(&devlink_mutex);
 
+       if (err != -EMSGSIZE)
+               return err;
+
        cb->args[0] = idx;
        return msg->len;
 }
-- 
2.21.0