Wed, Oct 02, 2019 at 07:52:30PM CEST, j...@resnulli.us wrote:
>Wed, Oct 02, 2019 at 10:40:56AM CEST, ido...@idosch.org wrote:
>>From: Ido Schimmel <ido...@mellanox.com>
>>
>>With the new notifications mlxsw does not need to handle identical
>>routes itself, as this is taken care of by the core IPv4 code.
>>
>>Instead, mlxsw only needs to take care of inserting and removing routes
>>from the device.
>>
>>Convert mlxsw to use the new IPv4 route notifications and simplify the
>>code.
>>
>
>[...]
>
>
>>@@ -6246,9 +6147,10 @@ static int mlxsw_sp_router_fib_event(struct
>>notifier_block *nb,
>> err = mlxsw_sp_router_fib_rule_event(event, info,
>> router->mlxsw_sp);
>> return notifier_from_errno(err);
>>- case FIB_EVENT_ENTRY_ADD:
>>+ case FIB_EVENT_ENTRY_ADD: /* fall through */
>> case FIB_EVENT_ENTRY_REPLACE: /* fall through */
>> case FIB_EVENT_ENTRY_APPEND: /* fall through */
>
>Why don't you skip the three above with just return of NOTIFY_DONE?
if (info->family == AF_INET)
return NOTIFY_DONE;
>
>
>>+ case FIB_EVENT_ENTRY_REPLACE_TMP:
>> if (router->aborted) {
>> NL_SET_ERR_MSG_MOD(info->extack, "FIB offload was
>> aborted. Not configuring route");
>> return notifier_from_errno(-EINVAL);
>>--
>>2.21.0
>>
