Re: [net-next 01/18] net/mlx5: Add flow steering actions to fs_cmd shim layer

[Saeed Mahameed]

On Mon, 2019-09-02 at 12:10 -0700, David Miller wrote:
> From: Saeed Mahameed <sae...@mellanox.com>
> Date: Mon, 2 Sep 2019 07:22:52 +0000
> 
> > +     maction->flow_action_raw.pkt_reformat =
> > +             mlx5_packet_reformat_alloc(dev->mdev, prm_prt, len,
> > +                                        in, namespace);
> > +     if (IS_ERR(maction->flow_action_raw.pkt_reformat))
> >               return ret;
> 
> Don't you have to initialize 'ret' to the pointer error here?
> 
> This transformation doesn't look correct.

Right! fixed in V2.

Thanks!