Re: [net-next 01/18] net/mlx5: Add flow steering actions to fs_cmd shim layer

[David Miller]

From: Saeed Mahameed <sae...@mellanox.com>
Date: Mon, 2 Sep 2019 07:22:52 +0000

> +     maction->flow_action_raw.pkt_reformat =
> +             mlx5_packet_reformat_alloc(dev->mdev, prm_prt, len,
> +                                        in, namespace);
> +     if (IS_ERR(maction->flow_action_raw.pkt_reformat))
>               return ret;

Don't you have to initialize 'ret' to the pointer error here?

This transformation doesn't look correct.