On 7/30/19 4:39 PM, Stephen Hemminger wrote:
On Mon, 22 Jul 2019 14:40:19 -0700 Shannon Nelson <snel...@pensando.io> wrote:+ +static void ionic_lif_set_netdev_info(struct lif *lif) +{ + struct ionic_admin_ctx ctx = { + .work = COMPLETION_INITIALIZER_ONSTACK(ctx.work), + .cmd.lif_setattr = { + .opcode = CMD_OPCODE_LIF_SETATTR, + .index = cpu_to_le16(lif->index), + .attr = IONIC_LIF_ATTR_NAME, + }, + }; + + strlcpy(ctx.cmd.lif_setattr.name, lif->netdev->name, + sizeof(ctx.cmd.lif_setattr.name)); + + dev_info(lif->ionic->dev, "NETDEV_CHANGENAME %s %s\n", + lif->name, ctx.cmd.lif_setattr.name); +There is already a kernel message for this. Repeating the same thing in the driver is redundant.
True, except for the lif name information. But since that really is debugging information, and I was getting tired of seeing those redundant messages, I was planning to remove them soon anyway. Thanks for the extra nudge.
sln
