Re: [PATCH nf] netfilter: nf_tables: map basechain priority to hardware priority

[Marcelo Ricardo Leitner]

On Tue, Jul 30, 2019 at 12:54:17PM +0200, Pablo Neira Ayuso wrote:
> This patch maps basechain netfilter priorities from -8192 to 8191 to
> hardware priority 0xC000 + 1. tcf_auto_prio() uses 0xC000 if the user
> specifies no priority, then it subtract 1 for each new tcf_proto object.
> This patch uses the hardware priority range from 0xC000 to 0xFFFF for
> netfilter.

This makes more sense, thanks Pablo.
Nit below.

> +u16 nft_chain_offload_priority(struct nft_base_chain *basechain)
> +{
> +     u16 prio;
> +
> +     if (basechain->ops.priority < NFT_BASECHAIN_OFFLOAD_PRIO_MIN ||
> +         basechain->ops.priority > NFT_BASECHAIN_OFFLOAD_PRIO_MAX)
> +             return 0;
> +
> +     /* map netfilter chain priority to hardware priority. */
> +     prio = basechain->ops.priority +
> +             NFT_BASECHAIN_OFFLOAD_PRIO_MAX +
> +                     NFT_BASECHAIN_OFFLOAD_HW_PRIO_BASE;

Weird indent here.

> +
> +     return prio;
> +}