On Tue, 30 Jul 2019 08:06:55 +0200, Jiri Pirko wrote: > >> diff --git a/drivers/net/netdevsim/netdevsim.h > >> b/drivers/net/netdevsim/netdevsim.h > >> index 79c05af2a7c0..cdf53d0e0c49 100644 > >> --- a/drivers/net/netdevsim/netdevsim.h > >> +++ b/drivers/net/netdevsim/netdevsim.h > >> @@ -19,6 +19,7 @@ > >> #include <linux/netdevice.h> > >> #include <linux/u64_stats_sync.h> > >> #include <net/devlink.h> > >> +#include <net/net_namespace.h> > > > >You can just do a forward declaration, no need to pull in the header. > > Sure, but why?
Less time to compile the kernel after net_namespace.h was touched. Don't we all spend more time that we would like to recompiling the kernel? :( Not a huge deal if you have a strong preference.
