Mon, Jul 29, 2019 at 10:21:11PM CEST, dsah...@gmail.com wrote:
>On 7/27/19 4:21 AM, Jiri Pirko wrote:
>>>> diff --git a/devlink/devlink.c b/devlink/devlink.c
>>>> index d8197ea3a478..9242cc05ad0c 100644
>>>> --- a/devlink/devlink.c
>>>> +++ b/devlink/devlink.c
>>>> @@ -32,6 +32,7 @@
>>>> #include "mnlg.h"
>>>> #include "json_writer.h"
>>>> #include "utils.h"
>>>> +#include "namespace.h"
>>>>
>>>> #define ESWITCH_MODE_LEGACY "legacy"
>>>> #define ESWITCH_MODE_SWITCHDEV "switchdev"
>>>> @@ -6332,7 +6333,7 @@ static int cmd_health(struct dl *dl)
>>>> static void help(void)
>>>> {
>>>> pr_err("Usage: devlink [ OPTIONS ] OBJECT { COMMAND | help }\n"
>>>> - " devlink [ -f[orce] ] -b[atch] filename\n"
>>>> + " devlink [ -f[orce] ] -b[atch] filename -N[etns]
>>>> netnsname\n"
>>>
>>> 'ip' uses lower-case n for this; why not be consistent?
>>
>> Because "n" is taken :/
>
>that's really unfortunate. commands within a package should have similar
>syntax and -n/N are backwards between ip/tc and devlink. That's the
>stuff that drives users crazy.
I agree. But this particular ship has sailed :(
