On Wed, Jun 5, 2019 at 12:58 PM David Ahern <d...@cumulusnetworks.com> wrote: > I think it is crazy to add multiple identical rules given the linear > effect on performance.
Not sure if this is what you were implying or not, but our code doesn't maintain multiple identical rules in steady state. It only uses them for make-before-break when something changes. > But, since it breaks Android, it has to be reverted. Well... the immediate problem on Android is that we cannot live with this going to LTS, since it is going to break devices in the field. As for making this change in 5.3: we might be able to structure the code differently in a future Android release, assuming the same userspace code can work on kernels back to 4.4 (not sure it can, since the semantics changed in 4.8). But even if we can fix this in Android, this change is still breaking compatibility with existing other userspace code. Are there concrete performance optimizations that you'd like to make that can't be made unless you change the semantics here? Are those optimizations worth breaking the backwards compatibility guarantees for?
