On 6/4/19 7:43 PM, Hangbin Liu wrote: > Hi David Ahern, > > On Fri, May 31, 2019 at 06:43:42PM -0700, Maciej Żenczykowski wrote: >> FYI, this userspace visible change in behaviour breaks Android. >> >> We rely on being able to add a rule and either have a dup be created >> (in which case we'll remove it later) or have it fail with EEXIST (in >> which case we won't remove it later). >> >> Returning 0 makes atomically changing a rule difficult. >> >> Please revert. > What do you think? Should I rever this commit?
I think it is crazy to add multiple identical rules given the linear effect on performance. But, since it breaks Android, it has to be reverted.
