From: Maxim Mikityanskiy <maxi...@mellanox.com>

Create a #define for the timeout of mlx5e_wait_for_min_rx_wqes to
clarify the meaning of a magic number.

Signed-off-by: Maxim Mikityanskiy <maxi...@mellanox.com>
Reviewed-by: Tariq Toukan <tar...@mellanox.com>
Signed-off-by: Saeed Mahameed <sae...@mellanox.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c 
b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
index 8ae17dcad487..69a9d67396ec 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
@@ -2256,14 +2256,18 @@ static void mlx5e_activate_channels(struct 
mlx5e_channels *chs)
                mlx5e_activate_channel(chs->c[i]);
 }
 
+#define MLX5E_RQ_WQES_TIMEOUT 20000 /* msecs */
+
 static int mlx5e_wait_channels_min_rx_wqes(struct mlx5e_channels *chs)
 {
        int err = 0;
        int i;
 
-       for (i = 0; i < chs->num; i++)
-               err |= mlx5e_wait_for_min_rx_wqes(&chs->c[i]->rq,
-                                                 err ? 0 : 20000);
+       for (i = 0; i < chs->num; i++) {
+               int timeout = err ? 0 : MLX5E_RQ_WQES_TIMEOUT;
+
+               err |= mlx5e_wait_for_min_rx_wqes(&chs->c[i]->rq, timeout);
+       }
 
        return err ? -ETIMEDOUT : 0;
 }
-- 
2.20.1

Reply via email to