On Sun, Apr 07, 2019 at 11:57:13AM +0200, Heiner Kallweit wrote:
> Recently genphy_read_abilities() has been added that dynamically detects
> clause 22 PHY abilities. I *think* this detection should work with all
> supported PHY's, at least for the ones with basic features sets, i.e.
> PHY_BASIC_FEATURES and PHY_GBIT_FEATURES. So let's remove setting these
> features explicitly and rely on phylib feature detection.
Hi Heiner
We could make this a two step process, to avoid regressions. For one
cycle compare genphy_read_abilities() against .features and raise a
WARN_ON() if they differ. And keep using the .features value.
Then a release late, complete the swap removing .features and the
WARN_ON.
Andrew
