From: Heiner Kallweit <hkallwe...@gmail.com> Date: Sat, 30 Mar 2019 10:22:45 +0100
> This patch improves few aspects of genphy_read_status(): > > - Don't initialize lpagb, it's not needed. > > - Move initializing phydev->speed et al before the if clause. > > - In auto-neg case, skip populating lp_advertising if we > don't have a link. This avoids quite some unnecessary > MDIO reads in case of phylib polling mode. > > Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> I decided that I'm not going to push back on this patch purely on the issue of not touching the conditional ordering. Applied, thanks Heiner.