On 31.03.2019 16:52, Andrew Lunn wrote:
>> - if (AUTONEG_ENABLE == phydev->autoneg) {
>> + if (phydev->autoneg == AUTONEG_ENABLE && phydev->link) {
>
> Hi Heiner
>
> I don't necessary agree with placing the constant first in the
> comparison, but it is best practice not to change it when making
> additions. It makes it a little bit harder to see what the actual
> change was.
>
I understand the point. However a patch to only change the order
of the operands most likely would also be rejected as not being
worth it. As a consequence we would have to live with it forever.
So I think it needs some "if we touch the code anyway" situation.
Or what would be the preferred way to change something like that
that is in general ok and can be just a little bit improved?
> Andrew
>
Heiner
