On 2019-02-21 16:17, Andrew Lunn wrote: >>>> config MDIO_BUS_MUX >>>> tristate >>>> depends on OF_MDIO >>>> + select MULTIPLEXER >>>> help >>>> This module provides a driver framework for MDIO bus >>>> multiplexers which connect one of several child MDIO busses >>> >>> Hi Pankaj >>> >>> Please add a MDIO_BUS_MUX_MULTIPLEXER and put all the code into mdio- >>> mux-multiplexer.c >> >> Isn't MUX short for MULTIPLEXER ? wouldn't this be more confusing ? > > Look at the pattern: > > config MDIO_BUS_MUX > config MDIO_BUS_MUX_BCM_IPROC > config MDIO_BUS_MUX_GPIO > config MDIO_BUS_MUX_MMIOREG > > You are adding another sort of MUX, A Mux that uses a kernel > Multiplexer. Hence the name should be MDIO_BUS_MUX_MULTIPLEXER. > > You can try to avoid confusion by using good help text: > > help This module provides a driver for MDIO bus multiplexer > that is controlled via the kernel multiplexer subsystem. The > bus multiplexer connects one of several child MDIO busses to > a parent bus. Child bus selection is under the control of > the kernel multiplexer subsystem. > > This test basically follows the other MDIO multiplexers.
The same "problem" happened for I2C muxes, and there the driver ended up being "i2c-mux-gpmux" with config symbol I2C_MUX_GPMUX, with GP being short for general purpose. If that matters... Cheers, Peter
