> -----Original Message-----
> From: Andrew Lunn [mailto:and...@lunn.ch]
> Sent: Thursday, 21 February, 2019 07:12 PM
> To: Pankaj Bansal <pankaj.ban...@nxp.com>
> Cc: Leo Li <leoyang...@nxp.com>; Peter Rosin <p...@axentia.se>; Florian
> Fainelli <f.faine...@gmail.com>; Heiner Kallweit <hkallwe...@gmail.com>;
> netdev@vger.kernel.org
> Subject: Re: [PATCH] drivers: net: phy: mdio-mux: Add support for Generic Mux
> controls
>
> On Thu, Feb 21, 2019 at 01:00:44PM +0000, Pankaj Bansal wrote:
> > Add support for Generic Mux controls, when Mdio mux node is a consumer
> > of mux produced by some other device.
> >
> > Signed-off-by: Pankaj Bansal <pankaj.ban...@nxp.com>
> > ---
> > drivers/net/phy/Kconfig | 1 +
> > drivers/net/phy/mdio-mux.c | 81 ++++++++++++++++++++++++++++++++++++
> > 2 files changed, 82 insertions(+)
> >
> > diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index
> > 3d187cd50eb0..e0e6b2b33d6d 100644
> > --- a/drivers/net/phy/Kconfig
> > +++ b/drivers/net/phy/Kconfig
> > @@ -47,6 +47,7 @@ config MDIO_BITBANG
> > config MDIO_BUS_MUX
> > tristate
> > depends on OF_MDIO
> > + select MULTIPLEXER
> > help
> > This module provides a driver framework for MDIO bus
> > multiplexers which connect one of several child MDIO busses
>
> Hi Pankaj
>
> Please add a MDIO_BUS_MUX_MULTIPLEXER and put all the code into mdio-
> mux-multiplexer.c
Isn't MUX short for MULTIPLEXER ? wouldn't this be more confusing ?
I have kept the mux APIs code unchanged, so as to not disturb the existing
drivers that use these APIs.
>
> > +static const struct of_device_id mdio_mux_match[] = {
> > + { .compatible = "mdio-mux", },
>
> mdio-mux-multiplexer
Again, isn't mux short for multiplexer? wouldn't this be more confusing ?
>
> Thanks
> Andrew
