Hi Jakub, I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Jakub-Kicinski/devlink-add-device-driver-information-API/20190131-222221 config: i386-randconfig-n0-01300126 (attached as .config) compiler: gcc-8 (Debian 8.2.0-15) 8.2.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): ld: net/core/ethtool.o: in function `ethtool_get_drvinfo': >> net/core/ethtool.c:809: undefined reference to >> `devlink_compat_running_versions' vim +809 net/core/ethtool.c 760 761 static noinline_for_stack int ethtool_get_drvinfo(struct net_device *dev, 762 void __user *useraddr) 763 { 764 struct ethtool_drvinfo info; 765 const struct ethtool_ops *ops = dev->ethtool_ops; 766 767 memset(&info, 0, sizeof(info)); 768 info.cmd = ETHTOOL_GDRVINFO; 769 if (ops->get_drvinfo) { 770 ops->get_drvinfo(dev, &info); 771 } else if (dev->dev.parent && dev->dev.parent->driver) { 772 strlcpy(info.bus_info, dev_name(dev->dev.parent), 773 sizeof(info.bus_info)); 774 strlcpy(info.driver, dev->dev.parent->driver->name, 775 sizeof(info.driver)); 776 } else { 777 return -EOPNOTSUPP; 778 } 779 780 /* 781 * this method of obtaining string set info is deprecated; 782 * Use ETHTOOL_GSSET_INFO instead. 783 */ 784 if (ops->get_sset_count) { 785 int rc; 786 787 rc = ops->get_sset_count(dev, ETH_SS_TEST); 788 if (rc >= 0) 789 info.testinfo_len = rc; 790 rc = ops->get_sset_count(dev, ETH_SS_STATS); 791 if (rc >= 0) 792 info.n_stats = rc; 793 rc = ops->get_sset_count(dev, ETH_SS_PRIV_FLAGS); 794 if (rc >= 0) 795 info.n_priv_flags = rc; 796 } 797 if (ops->get_regs_len) { 798 int ret = ops->get_regs_len(dev); 799 800 if (ret > 0) 801 info.regdump_len = ret; 802 } 803 804 if (ops->get_eeprom_len) 805 info.eedump_len = ops->get_eeprom_len(dev); 806 807 rtnl_unlock(); 808 if (!info.fw_version[0]) > 809 devlink_compat_running_versions(dev, info.fw_version, 810 ARRAY_SIZE(info.fw_version)); 811 rtnl_lock(); 812 813 if (copy_to_user(useraddr, &info, sizeof(info))) 814 return -EFAULT; 815 return 0; 816 } 817 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
