On Wed, 30 Jan 2019 22:57:52 +0100, Jiri Pirko wrote: > >+/* Control processor FW version, FW is responsible for house keeping tasks, > >+ * PHY control etc. > >+ */ > >+#define DEVLINK_VERSION_GENERIC_FW_MGMT "fw.mgmt" > >+/* Data path microcode controlling high-speed packet processing */ > >+#define DEVLINK_VERSION_GENERIC_FW_APP "fw.app" > >+/* UNDI software version */ > >+#define DEVLINK_VERSION_GENERIC_FW_UNDI "fw.undi" > >+/* NCSI support/handler version */ > >+#define DEVLINK_VERSION_GENERIC_FW_NCSI "fw.ncsi" > > Same here. Also, please put "INFO" in the names to respect the namespacing
Ack on all, and thanks for the reviews! Do you also think I should add a doc with them? I was going back and forth on that..
