On Sun, Jan 20, 2019 at 09:28:45AM +0100, Simon Horman wrote:
> On Thu, Jan 17, 2019 at 01:27:51PM +0000, Fabrizio Castro wrote:
> > Hello Simon,
> > 
> > Thank you for your feedback!
> > 
> > > From: Simon Horman <ho...@verge.net.au>
> > > Sent: 17 January 2019 12:00
> > > Subject: Re: [PATCH 07/11] arm64: dts: renesas: cat875: Add ethernet 
> > > support
> > >
> > > On Wed, Jan 16, 2019 at 06:37:50PM +0000, Fabrizio Castro wrote:
> > > > From: Biju Das <biju....@bp.renesas.com>
> > > >
> > > > This patch adds ethernet support to the sub board.
> > > >
> > > > Signed-off-by: Biju Das <biju....@bp.renesas.com>
> > > > Signed-off-by: Fabrizio Castro <fabrizio.cas...@bp.renesas.com>
> > > > Reviewed-by: Chris Paterson <chris.paters...@renesas.com>
> > > > ---
> > > >  arch/arm64/boot/dts/renesas/cat875.dtsi | 30 
> > > > ++++++++++++++++++++++++++++++
> > > >  1 file changed, 30 insertions(+)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/renesas/cat875.dtsi 
> > > > b/arch/arm64/boot/dts/renesas/cat875.dtsi
> > > > index a41d0d8..805ffa7 100644
> > > > --- a/arch/arm64/boot/dts/renesas/cat875.dtsi
> > > > +++ b/arch/arm64/boot/dts/renesas/cat875.dtsi
> > > > @@ -7,4 +7,34 @@
> > > >
> > > >  / {
> > > >  model = "Silicon Linux sub board for CAT874 (CAT875)";
> > > > +
> > > > +aliases {
> > > > +ethernet0 = &avb;
> > > > +};
> > > > +};
> > > > +
> > > > +&avb {
> > > > +pinctrl-0 = <&avb_pins>;
> > > > +pinctrl-names = "default";
> > > > +renesas,no-ether-link;
> > >
> > > Is the renesas,no-ether-link required?
> > 
> > The AVB_LINK pin from the SoC is connected to the PMEB (Power Management 
> > Event, B stands for
> > active low) pin on the  PHY, which means it is not a link signal. The PMEB 
> > signal is active when a magic
> > packet or a wake up frame are detected. As a result, we need 
> > renesas,no-ether-link and we can't
> > specify avb_link with avb_pin either.
> 
> Thanks for following-up. In that case I am fine with this patch.
> 

Thanks again, applied for v5.1.

Reply via email to