Hi!
> >+static int ksz_i2c_write32(struct ksz_device *dev, u32 reg, u32 value)
> >+{
> >+ value = cpu_to_be32(value);
> >+ return ksz_i2c_write(dev, reg, &value, 4);
> >+}
> >+
> >+static int ksz_i2c_get(struct ksz_device *dev, u32 reg, void *data, size_t
> >len)
> >+{
> >+ return ksz_i2c_read(dev, reg, data, len);
> >+}
> >+
> >+static int ksz_i2c_set(struct ksz_device *dev, u32 reg, void *data, size_t
> >len)
> >+{
> >+ return ksz_i2c_write(dev, reg, data, len);
> >+}
>
>
> This header file makes no sense. Please move the functions into .c
No, that would make code bigger & slower.
It makes sense to me. But I'd add "inline" keyword to make the goal
explicit.
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
signature.asc
Description: Digital signature
