On Tue, Dec 4, 2018 at 11:28 AM Saeed Mahameed <sae...@dev.mellanox.co.il> wrote: > > We are against having inline keywords in c file, so better if you > move this function to a header file an force the inline keyword there.
Two points: 1. The existing code without my patch has inline keyword. Why not move it from the beginning? 2. As I already mentioned, inline doesn't work with my patch, __always_inline does. Therefore, moving inline to a header doesn't make any difference.