On Mon, Dec 3, 2018 at 10:39 AM Cong Wang <xiyou.wangc...@gmail.com> wrote: > > On Sat, Dec 1, 2018 at 12:38 PM Cong Wang <xiyou.wangc...@gmail.com> wrote: > > > > is_last_ethertype_ip() is used to check IP/IPv6 protocol before > > parsing IP/IPv6 headers. > > One thing I noticed while reviewing the assembly code is that > is_last_ethertype_ip() is no longer inlined after this patch. > > I think I should keep it inlined by using __always_inline, as it is on > a hot path. > > What do you think, Tariq?
We are against having inline keywords in c file, so better if you move this function to a header file an force the inline keyword there.
