On Wed, Nov 21, 2018 at 2:40 PM, Eric Dumazet <eric.duma...@gmail.com> wrote: > > > On 11/21/2018 02:31 PM, Yuchung Cheng wrote: >> On Wed, Nov 21, 2018 at 9:52 AM, Eric Dumazet <eduma...@google.com> wrote: > >>> + >> Really nice! would it make sense to re-use (some of) the similar >> tcp_try_coalesce()? >> > > Maybe, but it is a bit complex, since skbs in receive queues (regular or out > of order) > are accounted differently (they have skb->destructor set) > > Also they had the TCP header pulled already, while the backlog coalescing > also has > to make sure TCP options match. > > Not sure if we want to add extra parameters and conditional checks... Makes sense.
Acked-by: Yuchung Cheng <ych...@google.com> > >
