On 11/8/18 2:30 PM, Andrew Lunn wrote: > On Thu, Nov 08, 2018 at 10:54:50PM +0100, Heiner Kallweit wrote: >> Flag PHY_HAS_INTERRUPT is used only here for this small check. I think >> using interrupts isn't possible if a driver defines neither >> config_intr nor ack_interrupts callback. So we can replace checking >> flag PHY_HAS_INTERRUPT with checking for these callbacks. >> >> This allows to remove this flag from a lot of driver configs, let's >> start with the Realtek driver. > > Hi Heiner > > Ideally, we should do this to all the drivers, not just one. If we > leave PHY_HAS_INTERRUPT, people are going to use it. That then makes > the realtek driver then different to all the other drivers, and at > some point somebody will do something which breaks it because they > don't know the realtek driver is special.
Agreed. -- Florian
