On 11/8/18 1:55 PM, Heiner Kallweit wrote: > Flag PHY_HAS_INTERRUPT is used only here for this small check. I think > using interrupts isn't possible if a driver defines neither > config_intr nor ack_interrupts callback. So we can replace checking > flag PHY_HAS_INTERRUPT with checking for these callbacks. > > Signed-off-by: Heiner Kallweit <[email protected]> > --- > drivers/net/phy/phy_device.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c > index d165a2c82..33e51b955 100644 > --- a/drivers/net/phy/phy_device.c > +++ b/drivers/net/phy/phy_device.c > @@ -2104,8 +2104,9 @@ static int phy_probe(struct device *dev) > /* Disable the interrupt if the PHY doesn't support it > * but the interrupt is still a valid one > */ > - if (!(phydrv->flags & PHY_HAS_INTERRUPT) && > - phy_interrupt_is_valid(phydev)) > + if (!phydrv->config_intr && > + !phydrv->ack_interrupt && > + phy_interrupt_is_valid(phydev)) > phydev->irq = PHY_POLL;
I would introduce an inline helper function which checks for drv->config_intr and config_ack_interrupt, that way if we ever have to introduce an additional function in the future, we just update the helper to check for that. Other than that, LGTM -- Florian
