> On Sep 18, 2018, at 2:46 PM, Eric Dumazet <eduma...@google.com> wrote: > > On Tue, Sep 18, 2018 at 2:41 PM Song Liu <songliubrav...@fb.com> wrote: >> >> >> >>> >> I would submit the patch if Eric prefer not to. :) > > > Hmmm.... maybe the bug is really in ixgbe_netpoll() > > This whole ndo_poll_controller() stuff is crazy. > > All sane implementations should only call napi_schedule() Current implement is about identical to napi_schedule_irqoff(). Do we really need napi_schedule() instead? On the other hand, I think we should check napi_complete_done() in ixgbe_poll() anyway. Song
- Re: pegged softirq and NAPI race (?) Alexei Starovoitov
- Re: pegged softirq and NAPI race (?) Eric Dumazet
- Re: pegged softirq and NAPI race (?) Song Liu
- Re: pegged softirq and NAPI race (?) Eric Dumazet
- Re: pegged softirq and NAPI race (?) Song Liu
- Re: pegged softirq and NAPI race ... Eric Dumazet
- Re: pegged softirq and NAPI race (?) Eric Dumazet
- Re: pegged softirq and NAPI race ... Jeff Kirsher
- Re: pegged softirq and NAPI race ... Song Liu
- Re: pegged softirq and NAPI race ... Eric Dumazet
- Re: pegged softirq and NAPI race ... Song Liu
- Re: pegged softirq and NAPI race ... Eric Dumazet
- Re: pegged softirq and NAPI race (?) Florian Fainelli
- Re: pegged softirq and NAPI race ... Eric Dumazet
- Re: pegged softirq and NAPI race ... Florian Fainelli
- Re: pegged softirq and NAPI race ... Song Liu