On 09/18/2018 02:28 PM, Eric Dumazet wrote: > On Tue, Sep 18, 2018 at 2:25 PM Florian Fainelli <f.faine...@gmail.com> wrote: >> >> >> This would not be the only driver doing this unfortunately... should we >> add a __must_check annotation to help catch those (mis)uses? Though that >> could cause false positives for drivers using NAPI to clean their TX ring. >> > > Well, before adding __must_check we would need to cook a (big) patch > series to change all occurrences. >
Sounds good, I don't mind submitting something unless you beat me to it. > > Not clear why netpoll is the trigger ? > Me either, this should be observable during normal operation as well, though most likely you just get a spurious interrupt and nothing to clean in the RX ring, so things just get unnoticed? -- Florian
