On 9/13/18 7:42 AM, Andrew Lunn wrote:
This is a pretty big patch, and is hard to review. Could you try to break it up into a number of smaller patches. You could for example first refactor emacs_phy_config(), without making any functional changes. Then add the sharing. Maybe do OF an ACPI in different patches?
Yes, please.