On Thu, Sep 13, 2018 at 05:04:53PM +0800, Wang Dongsheng wrote: > Share the mii_bus for others MAC device because QDF2400 emac > include MDIO, and the motherboard has more than one PHY connected > to an MDIO bus. > > Tested: QDF2400 (ACPI), buildin/insmod/rmmod > > Signed-off-by: Wang Dongsheng <dongsheng.w...@hxt-semitech.com>
Hi Wang This is a pretty big patch, and is hard to review. Could you try to break it up into a number of smaller patches. You could for example first refactor emacs_phy_config(), without making any functional changes. Then add the sharing. Maybe do OF an ACPI in different patches? Thanks Andrew