On Thu,  2 Aug 2018 22:45:58 +0000
Peter Oskolkov <p...@google.com> wrote:

> diff --git a/include/uapi/linux/snmp.h b/include/uapi/linux/snmp.h
> index e5ebc83827ab..da1a144f1a51 100644
> --- a/include/uapi/linux/snmp.h
> +++ b/include/uapi/linux/snmp.h
> @@ -40,6 +40,7 @@ enum
>       IPSTATS_MIB_REASMREQDS,                 /* ReasmReqds */
>       IPSTATS_MIB_REASMOKS,                   /* ReasmOKs */
>       IPSTATS_MIB_REASMFAILS,                 /* ReasmFails */
> +     IPSTATS_MIB_REASM_OVERLAPS,             /* ReasmOverlaps */
>       IPSTATS_MIB_FRAGOKS,                    /* FragOKs */
>       IPSTATS_MIB_FRAGFAILS,                  /* FragFails */
>       IPSTATS_MIB_FRAGCREATES,                /* FragCreates */

Inserting new entries in the middle of an enum means the numeric
values will change. Isn't this going to break userspace ABI?

Reply via email to