I am sorry for the late response. please read my comment bellow.
Jiri Benc wrote:
On Thu, 21 Sep 2006 09:59:39 -0700, mabbas wrote:
I can not see how does it break per-STA TX rate limit, especially
PRISM2_HOSTAPD_SET_RATE_SETS almost doing the same thing. I am not saying
the patch is correct I just want to know how to fix it to get it in.
As Jouni wrote, it's not useful to change the per-radio rate table. You
want to limit the rates you are using to communicate with the current AP
while not limiting other virtual interfaces. (Imagine you have the card
that is capable to associate to two APs at the same time. You don't want to
limit rates for both APs with SIOCSIWRATE.)
To do that I think the following is needed:
1. Add 'allowed_rates' field to struct sta_info. It defaults to 0xffffffff.
(Or perhaps call it 'disabled_rates' and make it default to 0.)
Should I add the new field to sta_info or to ieee80211_sub_if_data. If
we added to sta_info then it wont be persistent.
We will loose SIOCSIWRATE restriction once we associate with new AP.
Then in 3
we bitmask sta->curr_rates with ieee80211_sub_if_data::allowed_rates and
this will solve the problem for IBSS as well.
2. The SIOCSIWRATE handler: If the interface is not in a STA mode, return
-EOPNOTSUPP. Otherwise, modify the allowed_rates field of the sta entry
belonging to the current AP.
3. Bitmask sta->curr_rates with sta->allowed_rates (or
~sta->disabled_rates) in various places (ieee80211_ioctl_add_sta,
ieee80211_rx_mgmt_assoc_resp, ieee80211_rx_bss_info; please check for other
places).
In IBSS and AP mode setting this (per-STA, of course, which is not
supported by WE, btw.) can be useful as well but it can be done later.
Jiri
Thanks
Mohamed
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
