From: Roman Mashak <m...@mojatatu.com>
Date: Tue,  6 Mar 2018 16:55:23 -0500

> +static size_t tcf_action_fill_size(const struct tc_action *act)
> +{
> +     if (act->ops->get_fill_size)
> +             return act->ops->get_fill_size(act) +
> +                     tcf_action_shared_attrs_size(act);
> +     return 0;
> +}

I don't understand this.

The shared attrs should be considered regardless of whether an action
type specific ->get_fill_size() is implemented.

But instead, you return zero in that case.

Reply via email to