2018-01-16 10:33 UTC+0100 ~ Jiri Pirko <j...@resnulli.us>
> Tue, Jan 16, 2018 at 03:08:36AM CET, jakub.kicin...@netronome.com wrote:
>> From: Quentin Monnet <quentin.mon...@netronome.com>
>>
>> Prepare for extack support for hardware offload of classifiers. In order
>> to achieve this, a pointer to a struct netlink_ext_ack is added to the
>> struct tc_cls_common_offload that is passed to the callback for setting
>> up the classifier. Function tc_cls_common_offload_init() is updated to
>> support initialization of this new attribute.
>>
>> Extack plumbing is not complete yet.
>>
>> Signed-off-by: Quentin Monnet <quentin.mon...@netronome.com>
>> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com>
>> ---
>
> [...]
>
>
>> diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c
>> index 998ee4faf934..f1640a98a3d2 100644
>> --- a/net/sched/cls_flower.c
>> +++ b/net/sched/cls_flower.c
>> @@ -223,7 +223,7 @@ static void fl_hw_destroy_filter(struct tcf_proto *tp,
>> struct cls_fl_filter *f)
>> struct tc_cls_flower_offload cls_flower = {};
>> struct tcf_block *block = tp->chain->block;
>>
>> - tc_cls_common_offload_init(&cls_flower.common, tp);
>> + tc_cls_common_offload_init(&cls_flower.common, tp, NULL);
>
> You should have the patch assing extack arg to fl_hw_replace_filter
> prior to this patch. Then you don't need this odd NULL pass.
> Same for other cls.
It makes sense, thank you Jiri. I'll address this and your comment on
patch 9, and respin.
Quentin
