Stephen Hemminger wrote: > On Wed, 20 Dec 2017 09:37:29 +0200 > Serhey Popovych <serhe.popov...@gmail.com> wrote: > >> It is already given for original device we configure this >> peer for. >> >> Results from following command before/after change applied >> are shown below: >> >> $ ip link add dev veth1a type veth peer name veth1b \ >> type veth peer name veth1c >> >> Before: >> ------- >> >> <no output, no netdevs created> >> >> After: >> ------ >> >> Error: argument "type" is wrong: not supported for peer >> >> Signed-off-by: Serhey Popovych <serhe.popov...@gmail.com> > > This makes a lot of sense. > Maybe the better error message would be to use duparg() since > that is the most likely cause of the user error.
Not sure Stephen. With duparg() I get following error message for test case described in above. Error: duplicate "type": "veth" is the second value. It looks good for me, but we have two "type veth" in command and which one is wrong might not be very clear to user. Anyway I send v2 for this particular change to get and option to pick the best one. Thanks. >
signature.asc
Description: OpenPGP digital signature
